[PATCH] D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/WinException.cpp:760
+  if (Asm->MAI->usesWindowsCFI() &&
+      FuncInfo.UnwindHelpFrameIdx != std::numeric_limits<int>::max()) {
     AddComment("UnwindHelp");
----------------
efriedma wrote:
> I assume this is related somehow, but not sure how, exactly.
Ah, hmm. I think this might be leftovers from initial attempts at making things work for MSVC mode (for either C++ unwinding or SEH `__try`). I left that out of scope for now (itanium unwinding for mingw mode works fine without it though), so I guess I should leave it out here too.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFStreamer.cpp:114
+// 2) take an offset: SEH_StackAlloc, SEH_SaveFPLR, SEH_SaveFPLR_X
+// 3) take a register and an offset/size: all others
+void ARMTargetWinCOFFStreamer::emitARMWinUnwindCode(unsigned UnwindCode,
----------------
efriedma wrote:
> This comment is out-of-date?
Oh, oops. I guess I'll leave out the specifics of the opcodes here as I don't think it's relevant to elaborate on them here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125645/new/

https://reviews.llvm.org/D125645