[PATCH] D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 12:35:20 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/WinException.cpp:760
+  if (Asm->MAI->usesWindowsCFI() &&
+      FuncInfo.UnwindHelpFrameIdx != std::numeric_limits<int>::max()) {
     AddComment("UnwindHelp");
----------------
I assume this is related somehow, but not sure how, exactly.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFStreamer.cpp:114
+// 2) take an offset: SEH_StackAlloc, SEH_SaveFPLR, SEH_SaveFPLR_X
+// 3) take a register and an offset/size: all others
+void ARMTargetWinCOFFStreamer::emitARMWinUnwindCode(unsigned UnwindCode,
----------------
This comment is out-of-date?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125645/new/

https://reviews.llvm.org/D125645



More information about the llvm-commits mailing list