[PATCH] D126371: [SLP]Fix PR55688: Miscompile due to incorrect nuw handling.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 25 09:06:52 PDT 2022
spatel added a comment.
I'm not sure how this patch works on the given example, but I don't think it is sufficient.
We probably need to do what was suggested in the bug report - do not propagate flags when creating reduction ops.
We should add minimal tests that exercise these paths. For example, I don't think the patch works on this test:
https://alive2.llvm.org/ce/z/oZ703c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126371/new/
https://reviews.llvm.org/D126371
More information about the llvm-commits
mailing list