[PATCH] D126353: [X86] Add isSimple check to the load combine in combineExtractVectorElt.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 00:31:08 PDT 2022


craig.topper updated this revision to Diff 431894.
craig.topper added a comment.

Rebase. I used the wrong repo so it might have been older than I meant it to be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126353/new/

https://reviews.llvm.org/D126353

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp


Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -43520,7 +43520,7 @@
   auto *LoadVec = dyn_cast<LoadSDNode>(InputVector);
   if (LoadVec && CIdx && ISD::isNormalLoad(LoadVec) && VT.isInteger() &&
       SrcVT.getVectorElementType() == VT && DCI.isAfterLegalizeDAG() &&
-      !LikelyUsedAsVector) {
+      !LikelyUsedAsVector && LoadVec->isSimple()) {
     const TargetLowering &TLI = DAG.getTargetLoweringInfo();
     SDValue NewPtr =
         TLI.getVectorElementPointer(DAG, LoadVec->getBasePtr(), SrcVT, EltIdx);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126353.431894.patch
Type: text/x-patch
Size: 676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220525/d7d5fc37/attachment.bin>


More information about the llvm-commits mailing list