[PATCH] D125364: [RISCV] Replace ISD::FP_EXTEND and ISD::FP_ROUND with RVV VL op.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:827
+              (!cast<Instruction>(instruction_name#"_VV_"#vti.LMul.MX)
+                 vti.RegClass:$rs2, vti.RegClass:$rs1, GPR:$vl, vti.Log2SEW)>;
+    def : Pat<(op (wti.Vector (riscv_fpextend_vl_oneuse
----------------
craig.topper wrote:
> jacquesguan wrote:
> > craig.topper wrote:
> > > This is taking the VL from the fpextend_vl node, but the root node of the pattern has no VL operand. Shouldn't we still be using vti.AVL?
> > That would cause error `dead named input: $vl`.
> Yes it would, but's because we don't want that vl. I think you need to use `(XLenVT srcvalue)` instead of VLOpFrag.
Sorry about that, I think I mislead things. I got confused somewhat by these patterns previously being in the VL patterns file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125364/new/

https://reviews.llvm.org/D125364