[PATCH] D126254: Add support for decoding base64.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 14:23:43 PDT 2022


clayborg updated this revision to Diff 431794.
clayborg added a comment.

Address feedback:

- Handle any bad '=' characters separately before the main loop.
- Remember how many bytes to strip after decoding all bytes.
- Use "Inv" constexpr instead of the magic 64 number to make things more readable
- Update tests for changes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126254/new/

https://reviews.llvm.org/D126254

Files:
  llvm/include/llvm/Support/Base64.h
  llvm/unittests/Support/Base64Test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126254.431794.patch
Type: text/x-patch
Size: 7912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220524/eb91e7eb/attachment.bin>


More information about the llvm-commits mailing list