[PATCH] D126254: Add support for decoding base64.
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 23 22:45:40 PDT 2022
serge-sans-paille added inline comments.
================
Comment at: llvm/include/llvm/Support/Base64.h:68
+ if (Ch >= sizeof(DecodeTable))
+ return 64; // Invalid base64 value of 64, valid values are 0 - 63.
+ return DecodeTable[Ch];
----------------
I think declaring `constexpr char Invalid = 64` in the function prologue and then using it everywhere would also helps readability ;-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126254/new/
https://reviews.llvm.org/D126254
More information about the llvm-commits
mailing list