[PATCH] D126088: [RISCV] Add clarifying asserts to getFrameIndexReference [NFC]

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:696
+    // |--------------------------| -- <-- SP
     if (hasBP(MF)) {
       FrameReg = RISCVABI::getBPReg();
----------------
StephenFan wrote:
> Remove the curly bracket?
We generally prefer consistency between if and else.  The else block requires the bracket.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126088/new/

https://reviews.llvm.org/D126088