[PATCH] D126088: [RISCV] Add clarifying asserts to getFrameIndexReference [NFC]

[luxufan via Phabricator via llvm-commits]

StephenFan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:693
+    // | scalar local variables   | | <----'
+    // |--------------------------| -- <-- BP (if present)
+    // | VarSize objects          | |
----------------
reames wrote:
> StephenFan wrote:
> > Does `if present` means if the BP exists? But If both realignment and VarSize objects exist, then `BP` must be present.
> Please see the code immediately below this.  If you have a suggestion on the comment wording, feel free to suggest something.  
Oh, I see. Now it's ok. Thanks


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:696
+    // |--------------------------| -- <-- SP
     if (hasBP(MF)) {
       FrameReg = RISCVABI::getBPReg();
----------------
Remove the curly bracket?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126088/new/

https://reviews.llvm.org/D126088