[PATCH] D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb marked an inline comment as done.
maksfb added inline comments.


================
Comment at: llvm/lib/Target/Sparc/Disassembler/SparcDisassembler.cpp:512
   return Decoder->tryAddingSymbolicOperand(MI, Value, Address, isBranch, Offset,
-                                           Width);
+                                           Width, /*InstSize=*/0);
 }
----------------
skan wrote:
> Why is "0" used as argument here? Is it unused?
Correct. Although for SPARC it's safe to use 4.


================
Comment at: llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp:53
+
+  operator bool() { return Ctx.get(); }
+  operator MCContext &() { return *Ctx; };
----------------
skan wrote:
> Is this function unused?
Yes, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126101/new/

https://reviews.llvm.org/D126101