[PATCH] D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 23 18:36:06 PDT 2022
skan added inline comments.
================
Comment at: llvm/lib/Target/Sparc/Disassembler/SparcDisassembler.cpp:512
return Decoder->tryAddingSymbolicOperand(MI, Value, Address, isBranch, Offset,
- Width);
+ Width, /*InstSize=*/0);
}
----------------
Why is "0" used as argument here? Is it unused?
================
Comment at: llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp:53
+
+ operator bool() { return Ctx.get(); }
+ operator MCContext &() { return *Ctx; };
----------------
Is this function unused?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126101/new/
https://reviews.llvm.org/D126101
More information about the llvm-commits
mailing list