[PATCH] D126112: [BOLT] Increase coverage of shrink wrapping [2/5]

[Amir Ayupov via Phabricator via llvm-commits]

Amir accepted this revision.
Amir added a comment.
This revision is now accepted and ready to land.

LGTM but didn't check every new line.



================
Comment at: bolt/lib/Target/X86/X86MCPlusBuilder.cpp:1076
     }
+    // TODO: Find a way to encode this info into tablegen somehow / fetch via MC
+    // We need to query how wide, in bytes, is the memory access of a given inst
----------------
There might be a way to fetch memory access size: D126116 (WIP).
Regarding the rest of the fields: IsLoad/IsStore are straightforward. `StoreFromReg` and `IsSimple` are somewhat difficult. Let's address them later.

I think it's best to pull this diff in, and remove it later with D126116 after NFC testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126112/new/

https://reviews.llvm.org/D126112