[PATCH] D126085: [RISCV] Add a subtarget feature to enable unaligned loads
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 20 13:39:45 PDT 2022
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:11816
if (Fast)
*Fast = true;
return true;
----------------
Not directly related to this patch, but it could be argued that *Fast = true is incorrect for vectors here. Being element aligned doesn't guarantee optimal access if you're splitting a cache line or other alignment requirements of your memory unit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126085/new/
https://reviews.llvm.org/D126085
More information about the llvm-commits
mailing list