[PATCH] D126085: [RISCV] Add a subtarget feature to enable unaligned loads

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 13:14:55 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:11820
 
-  return false;
+  return Subtarget.enableUnalignedMem();
 }
----------------
reames wrote:
> craig.topper wrote:
> > This seems like it should be a different feature for vectors.
> There might be such a target where scalar vs vector matters, but on the motivating case, this is not expected to matter.  We can split later if needed.
There are no vector tests and the description in the .td file says “scalar”. The patch should at least be self consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126085/new/

https://reviews.llvm.org/D126085



More information about the llvm-commits mailing list