[PATCH] D125971: [RISCV] Ensure the forwarded AVL register is alive

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1213
         else
           VLOp.ChangeToRegister(CurInfo.getAVLReg(), /*IsDef*/ false);
         CurInfo = computeInfoForInstr(MI, TSFlags, MRI);
----------------
reames wrote:
> Here
I'm pretty sure this one is always X0, since that's the only register hasNonZeroAVL/hasZeroAVL work for. But we should assert to be safe.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1260
                   VLOp.ChangeToImmediate(DefInfo.getAVLImm());
                 else
                   VLOp.ChangeToRegister(DefInfo.getAVLReg(), /*IsDef*/ false);
----------------
reames wrote:
> Here
This one is always X0. I don't think MRI knows about the uses of X0 to find kill flags to clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125971/new/

https://reviews.llvm.org/D125971