[PATCH] D125971: [RISCV] Ensure the forwarded AVL register is alive

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Oh, good catch!

We have the same bug in several places in this code, would you mind updating the fix to include all three?  I tagged them inline.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1213
         else
           VLOp.ChangeToRegister(CurInfo.getAVLReg(), /*IsDef*/ false);
         CurInfo = computeInfoForInstr(MI, TSFlags, MRI);
----------------
Here


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1260
                   VLOp.ChangeToImmediate(DefInfo.getAVLImm());
                 else
                   VLOp.ChangeToRegister(DefInfo.getAVLReg(), /*IsDef*/ false);
----------------
Here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125971/new/

https://reviews.llvm.org/D125971