[PATCH] D125784: [llvm-dva] 09 - CodeView Reader

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp:54
+
+uint64_t llvm::codeview::getSize(TypeIndex TI) {
+  if (!TI.isSimple())
----------------
CarlosAlbertoEnciso wrote:
> djtodoro wrote:
> > I guess this should be a standalone patch.
> > 
> > What about `getSizeInBytes()` instead?
> That is a very good point.
> Would you prefer all the changes to `TypeRecordHelpers.cpp[h]` be moved in a standalone patch?
> `getSizeInBytes()` sounds good.
> Would you prefer all the changes to TypeRecordHelpers.cpp[h] be moved in a standalone patch?
I vote for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784