[PATCH] D125784: [llvm-dva] 09 - CodeView Reader
Carlos Alberto Enciso via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 18 03:23:09 PDT 2022
CarlosAlbertoEnciso added inline comments.
================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp:54
+
+uint64_t llvm::codeview::getSize(TypeIndex TI) {
+ if (!TI.isSimple())
----------------
djtodoro wrote:
> I guess this should be a standalone patch.
>
> What about `getSizeInBytes()` instead?
That is a very good point.
Would you prefer all the changes to `TypeRecordHelpers.cpp[h]` be moved in a standalone patch?
`getSizeInBytes()` sounds good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125784/new/
https://reviews.llvm.org/D125784
More information about the llvm-commits
mailing list