[PATCH] D124192: [AMDGPU] Callee must always spill writelane VGPRs
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 17 15:06:58 PDT 2022
arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1052
+ auto VGPR = Reg.first;
+ auto FI = Reg.second;
+ if (!FI)
----------------
No auto
================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:496
+ using LaneVGPRsMap = MapVector<Register, Optional<int>>;
+ LaneVGPRsMap LaneVGPRs;
----------------
Needs a comment for what lane VGPRs are
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124192/new/
https://reviews.llvm.org/D124192
More information about the llvm-commits
mailing list