[PATCH] D124671: [AMDGPU] Do not raise wave priority beyond a specific number of VALU instructions.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 17 14:46:44 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSetWavePriority.cpp:198-199
+ if (MachineInstr *LastVMEMLoad = MBBInfos[MBB].LastVMEMLoad) {
+ MBB->insertAfter(MachineBasicBlock::instr_iterator(LastVMEMLoad),
+ Setprio);
+ continue;
----------------
kosarev wrote:
> arsenm wrote:
> > Why not construct directly at the insert point?
> Well, the instruction we create here is not just an auxiliary value that we coincidentally happen to use in both the cases, if that's what you mean. That instruction must be spent in all cases and we do want it be the same instruction.
But you can construct it in the right place rather than constructing the instruction and then inserting after. You have the insert point you want, you can just construct it there? It's unusual to need insert/insertAfter
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124671/new/
https://reviews.llvm.org/D124671
More information about the llvm-commits
mailing list