[PATCH] D125759: [AMDGPU] Remove isLiteralConstant and isLiteralConstantLike

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:3603-3604
                                    uint8_t OperandType) const {
+  if (MO.isReg())
+    return true;
   if (!MO.isImm() ||
----------------
arsenm wrote:
> This doesn't make any sense to me
Yeah, so this function needs a better name - something that means "is this operand guaranteed not to make the instruction 4 bytes bigger?". I suppose that is (the converse of) what the isLiteralConstantLike name was supposed to imply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125759/new/

https://reviews.llvm.org/D125759