[PATCH] D125735: [OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 00:47:20 PDT 2022


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG. This seems like a good path towards wider default-enablement of opaque pointers without updating all the tests first.



================
Comment at: llvm/lib/AsmParser/LLParser.cpp:70
+      if (K == lltok::star)
+        C.setOpaquePointers(false);
       return;
----------------
For anyone else confused, this whole code only runs with `!hasSetOpaquePointersValue()`, so no need to check it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125735/new/

https://reviews.llvm.org/D125735



More information about the llvm-commits mailing list