[PATCH] D125735: [OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 17:03:17 PDT 2022


aeubanks created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

If we turn on --opaque-pointers, tests with '*' would use opaque pointers.

Can't really test this without flipping the default value for --opaque-pointers.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125735

Files:
  llvm/lib/AsmParser/LLParser.cpp


Index: llvm/lib/AsmParser/LLParser.cpp
===================================================================
--- llvm/lib/AsmParser/LLParser.cpp
+++ llvm/lib/AsmParser/LLParser.cpp
@@ -66,6 +66,8 @@
     // explicit "ptr".
     if (K == lltok::star || K == lltok::Error || K == lltok::Eof ||
         isa_and_nonnull<PointerType>(L.getTyVal())) {
+      if (K == lltok::star)
+        C.setOpaquePointers(false);
       return;
     }
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125735.429902.patch
Type: text/x-patch
Size: 438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220517/302cf111/attachment.bin>


More information about the llvm-commits mailing list