[PATCH] D124884: [AMDGPU] Add intrinsics llvm.amdgcn.{raw|struct}.buffer.load.lds

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3080
+  default:
+    llvm_unreachable("Unhandled buffer load LDS size");
+  case 1:
----------------
Should return false, the verifier isn't enforcing this


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3130
+
+  MachineMemOperand *LoadMMO = *MI.memoperands_begin();
+  MachinePointerInfo LoadPtrI = LoadMMO->getPointerInfo();
----------------
The verifier should probably be enforcing MMO ordering if you're going to rely on that


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:8254
+    default:
+      llvm_unreachable("Unhandled buffer load LDS size");
+    case 1:
----------------
Ditto, verifier isn't enforcing this so shouldn't assert


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124884/new/

https://reviews.llvm.org/D124884