[PATCH] D125404: [SPIR-V] Add simple tests to improve test coverage

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/SPIRV/TruncToBool.ll:9-10
+; ModuleID = 'main'
+target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
+target triple = "spirv64-unknown-unknown"
+
----------------
Generally tests use -mtriple on the command line and don't repeat the triple/datalayout in the IR


================
Comment at: llvm/test/CodeGen/SPIRV/llvm-intrinsics/dynamic-memmove.ll:3
+
+; CHECK-SPIRV-NOT: llvm.memmove
+
----------------
Negative tests are extremely fragile. Should check what is actually emitted here


================
Comment at: llvm/test/CodeGen/SPIRV/llvm-intrinsics/experimental.noalias.scope.decl.ll:6
+
+; CHECK-NOT: llvm.experimental.noalias.scope.decl
+declare void @llvm.experimental.noalias.scope.decl(metadata)
----------------
Ditto?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404