[PATCH] D125404: [SPIR-V] Add simple tests to improve test coverage

Aleksandr Bezzubikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 13:39:23 PDT 2022


zuban32 added inline comments.


================
Comment at: llvm/test/CodeGen/SPIRV/optnone.ll:17
+
+attributes #0 = { nounwind optnone noinline "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
Some (or all) of these attributes look redundant as well


================
Comment at: llvm/test/CodeGen/SPIRV/transcoding/OpBitReverse_i32.ll:13
+  %call = tail call i32 @llvm.bitreverse.i32(i32 %b)
+  store i32 %call, i32 addrspace(1)* %res, align 4, !tbaa !7
+  ret void
----------------
`tbaa` metadata is not needed too


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404



More information about the llvm-commits mailing list