[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Analysis/BasicBlockSectionsProfileReader.h:48
+
+using ProgramBBClusterInfoMapTy = StringMap<SmallVector<BBClusterInfo, 4>>;
+
----------------
rahmanl wrote:
> MaskRay wrote:
> > Check whether you want to use `SmallVector<BBClusterInfo, 0>` to make the element size smaller.
> How about `SmallVector<BBClusterInfo>` for the absence of a strongly-motivated choice as advised in https://llvm.org/doxygen/classllvm_1_1SmallVector.html ?
That's also fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122930/new/

https://reviews.llvm.org/D122930