[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/include/llvm/Analysis/BasicBlockSectionsProfileReader.h:48
+
+using ProgramBBClusterInfoMapTy = StringMap<SmallVector<BBClusterInfo, 4>>;
+
----------------
MaskRay wrote:
> Check whether you want to use `SmallVector<BBClusterInfo, 0>` to make the element size smaller.
How about `SmallVector<BBClusterInfo>` for the absence of a strongly-motivated choice as advised in https://llvm.org/doxygen/classllvm_1_1SmallVector.html ?


================
Comment at: llvm/lib/Analysis/BasicBlockSectionsProfileReader.cpp:1
+//===-- BasicBlockSectionsProfileReader.cpp
+//---=========----------------------------===//
----------------
MaskRay wrote:
> Not sure the Reader should be placed in lib/Analysis. There is no precedent.
Moved to CodeGen (where we have MIRSampleProfile.cpp).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122930/new/

https://reviews.llvm.org/D122930