[PATCH] D125382: [RISCV] Add a test w/ RVV stack objects misaligning non-RVV ones

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/scalar-stack-align.ll:4
+; RUN:   | FileCheck %s --check-prefix=RV32
+; RUN: llc -mtriple=riscv64 -mattr=+v -verify-machineinstrs < %s \
+; RUN:   | FileCheck %s --check-prefix=RV64
----------------
kito-cheng wrote:
> `v` implied `zvl128b` which guarantee VLEN is at least 128, so maybe `zve32*` or `zve64*`? they only implied `zvl64b`/`zvl32b`.
Yeah, you're right. In future patches I'll probably want both `zve64` and `v` to show that with `v` we can rely on `vlen`'s alignment rather than padding the stack. The question is whether I should add both RUN lines now or later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125382/new/

https://reviews.llvm.org/D125382