[PATCH] D125609: [ADT] Adopt the new casting infrastructure for PointerUnion

[Sheng via Phabricator via llvm-commits]

0x59616e updated this revision to Diff 429508.
0x59616e marked an inline comment as done.
0x59616e added a comment.

Implement `CastInfoPointerUnionImpl`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125609/new/

https://reviews.llvm.org/D125609

Files:
  llvm/include/llvm/ADT/PointerUnion.h


Index: llvm/include/llvm/ADT/PointerUnion.h
===================================================================
--- llvm/include/llvm/ADT/PointerUnion.h
+++ llvm/include/llvm/ADT/PointerUnion.h
@@ -139,6 +139,9 @@
 
   explicit operator bool() const { return !isNull(); }
 
+  // FIXME: Replace the uses of is(), get() and dyn_cast() with
+  //        isa<T>, cast<T> and the llvm::dyn_cast<T>
+
   /// Test if the Union currently holds the type matching T.
   template <typename T> inline bool is() const { return isa<T>(*this); }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125609.429508.patch
Type: text/x-patch
Size: 534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220515/a0ff2fc6/attachment.bin>