[PATCH] D125609: [ADT] Adopt the new casting infrastructure for PointerUnion

[Aman LaChapelle via Phabricator via llvm-commits]

bzcheeseman added inline comments.


================
Comment at: llvm/include/llvm/ADT/PointerUnion.h:212
+struct CastInfo<To, PointerUnion<PTs...>>
+    : NullableValueCastFailed<To>,
+      DefaultDoCastIfPossible<To, PointerUnion<PTs...>,
----------------
I think you'll need public inheritance here and below? Otherwise I'd expect that you get compiler errors saying this partial specialization doesn't define the functions you need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125609/new/

https://reviews.llvm.org/D125609