[PATCH] D125544: [lld][ELF] Support linking 'elf32-avr' with linker scripts

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/linkerscript/avr5-sections.test:1
+# REQUIRES: avr
+
----------------
benshi001 wrote:
> MaskRay wrote:
> > The tests should be merged into one.
> > 
> > Add a file-level comment explaining the purpose.
> > 
> > Use split-file to avoid `Inputs/*` files.
> I am not familiar with that.
> 
> do you mean:
> 1. make a unique .s file with assembly
> 2. echo to a temp linker script
> 3. do all checks ? 
`rg split-file` in this directory and see I use split-file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125544/new/

https://reviews.llvm.org/D125544