[PATCH] D125544: [lld][ELF] Support linking 'elf32-avr' with linker scripts

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 14 18:03:33 PDT 2022


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: lld/test/ELF/linkerscript/avr5-sections.test:1
+# REQUIRES: avr
+
----------------
MaskRay wrote:
> The tests should be merged into one.
> 
> Add a file-level comment explaining the purpose.
> 
> Use split-file to avoid `Inputs/*` files.
I am not familiar with that.

do you mean:
1. make a unique .s file with assembly
2. echo to a temp linker script
3. do all checks ? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125544/new/

https://reviews.llvm.org/D125544



More information about the llvm-commits mailing list