[PATCH] D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias()

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/include/llvm/IR/IRBuilder.h:544
+  /// Fetch the type representing a pointer.
+  PointerType *getPtrTy(unsigned AddrSpace = 0) {
+    return PointerType::get(Context, AddrSpace);
----------------
arichardson wrote:
> arichardson wrote:
> > Would it be possible to drop the default zero argument for new APIs? Defaulting to AS0 instead of explicitly passing address spaces often causes assertion errors for targets such as AVR or the downstream CHERI-RISC-V and Arm Morello targets.
> o 
As somebody unfamiliar with those targets, what would be the right thing to pass in various cases?
And if you're interested in dropping the default argument, I think it would be better to do that all at once for all APIs.

Is it possible to add in-tree testing for the sort of thing you're interested in without upstreaming an entire target?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125328/new/

https://reviews.llvm.org/D125328