[PATCH] D124865: [AIX] support read global symbol of big archive

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 10:28:38 PDT 2022


DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/Archive.cpp:1208
+    unsigned SymNum = getNumberOfSymbols();
+    unsigned SizeOfSymOffSets = 8 * (SymNum + 1);
+    uint64_t SymbolTableStringSize = Size - SizeOfSymOffSets;
----------------
jhenderson wrote:
> This is a shorter name (plus the "S" in "Offsets" shouldn't be capitalized).
thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124865/new/

https://reviews.llvm.org/D124865



More information about the llvm-commits mailing list