[PATCH] D125552: [RISCV] Add llvm.read.register support for vlenb

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D125552#3512011 <https://reviews.llvm.org/D125552#3512011>, @reames wrote:

> In D125552#3511824 <https://reviews.llvm.org/D125552#3511824>, @reames wrote:
>
>> In D125552#3511820 <https://reviews.llvm.org/D125552#3511820>, @craig.topper wrote:
>>
>>> Should we eventually implement something like AArch64DAGToDAGISel::tryReadRegister?
>>
>> I think that basically comes down to a question of whether we think having the ccsr exposed earlier than COPY elimination is helpful.  I don't currently have a strong opinion on that, but would lean towards using the generic COPY through optimization.
>
> This is absolutely what I did.  Thanks!  Fixed properly in 853fa8ee <https://reviews.llvm.org/rG853fa8ee225edf2d0de94b0dcbd31bea916e825e>.  Though I am surprised the register type auto-converts to something TII accepts...

The code base isn't clean on use of Register so there is an `operator unsigned()` I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125552/new/

https://reviews.llvm.org/D125552