[PATCH] D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:728
 
+  void subtractTotalSamples(uint64_t Num) {
+    if (TotalSamples < Num)
----------------
wenlei wrote:
> nit: now that we have a `removeSamples`, name this `removeTotalSamples`.
Sounds good.


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:27
 #include <system_error>
+#include <utility>
 
----------------
wenlei wrote:
> Is this needed?
Good catch. It's not. It was automatically added by my editor,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125266/new/

https://reviews.llvm.org/D125266