[PATCH] D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 23:17:18 PDT 2022


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm except nits.



================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:728
 
+  void subtractTotalSamples(uint64_t Num) {
+    if (TotalSamples < Num)
----------------
nit: now that we have a `removeSamples`, name this `removeTotalSamples`.


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:27
 #include <system_error>
+#include <utility>
 
----------------
Is this needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125266/new/

https://reviews.llvm.org/D125266



More information about the llvm-commits mailing list