[PATCH] D125498: [AMDGPU] gfx11 scalar alu instructions

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:1287
 let Uses = [EXEC, M0] in {
-// FIXME: Should this be mayLoad+mayStore?
 def S_SENDMSG : SOPP_Pseudo <"s_sendmsg" , (ins SendMsgImm:$simm16), "$simm16",
----------------
This hunk is nothing to do with GFX11, right? Please commit it separately (consider it pre-approved).


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:1596
+
+
 defm S_ANDN1_SAVEEXEC_B64   : SOP1_Real_gfx10<0x037>;
----------------
One blank line is enough :)


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:1754
+  SOP2_Real_gfx10<op>, SOP2_Real_gfx11<op>;
+
+
----------------
One blank line is enough :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125498/new/

https://reviews.llvm.org/D125498