[PATCH] D125498: [AMDGPU] gfx11 scalar alu instructions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:6394
+    Value = StringSwitch<int>(ValueName)
+                .Case("SAME", 0)
+                .Case("NEXT", 1)
----------------
All these magic numbers shall go into SIDefines.h.


================
Comment at: llvm/test/MC/AMDGPU/gfx11_pretest.s:1
+// RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
+
----------------
What does 'pretest' mean in the file name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125498/new/

https://reviews.llvm.org/D125498