[PATCH] D125482: [LLVM][Casting.h] Don't create a temporary while casting.

Jake Egan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 14:06:31 PDT 2022


Jake-Egan added a comment.

In D125482#3510072 <https://reviews.llvm.org/D125482#3510072>, @bzcheeseman wrote:

> In D125482#3510066 <https://reviews.llvm.org/D125482#3510066>, @Jake-Egan wrote:
>
>> Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio
>>
>> I applied your patch here and it seems to fix the original error, but there is a new one:
>>
>>   /llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:69:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
>>     cast<MyBaseType>(D);
>>     ^~~~~~~~~~~~~~~~ ~
>>   /llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:70:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
>>     cast<MyBaseType>(BD);
>>     ^~~~~~~~~~~~~~~~ ~~
>>   /llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:71:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
>>     cast<MyDerivedType>(BD);
>>     ^~~~~~~~~~~~~~~~~~~ ~~
>
> This commit went in last night it looks like to fix that: 52328dafda13711653fd15aa4db34db350471a1f <https://reviews.llvm.org/rG52328dafda13711653fd15aa4db34db350471a1f>

Oh my mistake, my branch was only up to the other commit. Thank you


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125482/new/

https://reviews.llvm.org/D125482



More information about the llvm-commits mailing list