[PATCH] D125482: [LLVM][Casting.h] Don't create a temporary while casting.

[Jake Egan via Phabricator via llvm-commits]

Jake-Egan added a comment.

Hi, we're also getting the original error on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1255/steps/6/logs/stdio

I applied your patch here and it seems to fix the original error, but there is a new one:

  /llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:69:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
    cast<MyBaseType>(D);
    ^~~~~~~~~~~~~~~~ ~
  /llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:70:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
    cast<MyBaseType>(BD);
    ^~~~~~~~~~~~~~~~ ~~
  /llvm-project/llvm/unittests/Support/ExtensibleRTTITest.cpp:71:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
    cast<MyDerivedType>(BD);
    ^~~~~~~~~~~~~~~~~~~ ~~


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125482/new/

https://reviews.llvm.org/D125482