[PATCH] D124514: [ArgPromotion] Make a non-byval promotion attempt first

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D124514#3491237 <https://reviews.llvm.org/D124514#3491237>, @psamolysov wrote:

> And I see that the "usual" (non-byval) promotion uses `i64` for the second argument of the generated `GEP` instructions:
> [...]
> Does this work as designed?

The index type to use is specified by DataLayout -- however, other index types will be automatically sign extended or truncated. So it's fine either way, though using the correct index type (i64 by default) is preferred. Struct indices always use i32 though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124514/new/

https://reviews.llvm.org/D124514