[PATCH] D123949: [AIX] support write operation of big archive.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 06:57:04 PDT 2022


DiggerLin marked 17 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:737
+                          20); // Offset to member table
+    printWithSpacePadding(Out, NewMembers.size() ? GlobalSymbolOffset : 0, 20);
+    printWithSpacePadding(
----------------
jhenderson wrote:
> Missing comment? Also, I don't understandwhy the global symbol table offset is dependent on the size of `NewMembers`?
I added a comment in the source code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123949/new/

https://reviews.llvm.org/D123949



More information about the llvm-commits mailing list