[PATCH] D123949: [AIX] support write operation of big archive.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 06:20:22 PDT 2022


DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:658
+  // The symbol table is put at the end of the big archive file. The symbol
+  // table is at the begin of the archive file for other archive format.
+  if (WriteSymtab && !isAIXBigArchive(Kind)) {
----------------
jhenderson wrote:
> `begin` is a verb, not a noun. You need `beginning` or `start` (`start` is probably preferable).
thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123949/new/

https://reviews.llvm.org/D123949



More information about the llvm-commits mailing list