[PATCH] D123949: [AIX] support write operation of big archive.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 12 00:36:25 PDT 2022
jhenderson added a comment.
Just some nits left from me.
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:658
+ // The symbol table is put at the end of the big archive file. The symbol
+ // table is at the begin of the archive file for other archive format.
+ if (WriteSymtab && !isAIXBigArchive(Kind)) {
----------------
`begin` is a verb, not a noun. You need `beginning` or `start` (`start` is probably preferable).
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:740
+ 20); // Offset to member table
+ // If there is no file members in the archive, there will be no global
+ // symbol table.
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123949/new/
https://reviews.llvm.org/D123949
More information about the llvm-commits
mailing list