[PATCH] D125404: [SPIRV] Add SPIR-V tests

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In D125404#3508472 <https://reviews.llvm.org/D125404#3508472>, @andreytr wrote:

> Concerning "`[[#]]` instead of `{{[0-9]+}}`":
> This style `{{[0-9]+}}` is widely used in SPIRV-LLVM-Translator's tests repository. So, it has to change nearly 150-200 converted tests in LLVM-SPIRV-Backend' tests repository. (?) Moreover, it will break link to original source SPIRV-LLVM-Translator's tests.
> Is it required?

Not strictly required, no. A quick grep in `llvm/test` shows 65 occurrences of `[[#]]` and 80388 of the regexp style.

On FileCheck's manual, this [1] is why `[[#]]` is equivalent and simpler, but also there are examples in the regexp form, which is also valid.

I'd say this could be a NFC change later to do all at once, but still isn't strictly necessary, it'd just be nice to start with a simpler pattern, then copy-and-paste later propagates it naturally.

[1] https://www.llvm.org/docs/CommandGuide/FileCheck.html#filecheck-numeric-substitution-blocks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404