[PATCH] D125404: [SPIRV] Add SPIR-V tests

Andrey Tretyakov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 02:23:53 PDT 2022


andreytr added a comment.

Yes, these are the only tests currently passing.

@MaskRay :
Concerning "`[[#]]` instead of `{{[0-9]+}}`":
This style `{{[0-9]+}}` is widely used in SPIRV-LLVM-Translator's tests repository. So, it has to change nearly 150-200 converted tests in LLVM-SPIRV-Backend' tests repository. (?) Moreover, it will break link to original source SPIRV-LLVM-Translator's tests.
Is it required?

The rest things (whitespaces and comments) I will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404



More information about the llvm-commits mailing list