[llvm] 852f3d9 - Revert "[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp"

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 19:53:57 PDT 2022


Author: Mingming Liu
Date: 2022-05-10T19:53:31-07:00
New Revision: 852f3d9987877e8bd315e3de021ec99e925991b1

URL: https://github.com/llvm/llvm-project/commit/852f3d9987877e8bd315e3de021ec99e925991b1
DIFF: https://github.com/llvm/llvm-project/commit/852f3d9987877e8bd315e3de021ec99e925991b1.diff

LOG: Revert "[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp"

This reverts commit 8bef5476de3ec7388ad0c72b26dcc82ac7fd970a.

Need to revert, update commit message and reapply.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86InstrInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86InstrInfo.cpp b/llvm/lib/Target/X86/X86InstrInfo.cpp
index 831142a66d6b..f4ffb42d9972 100644
--- a/llvm/lib/Target/X86/X86InstrInfo.cpp
+++ b/llvm/lib/Target/X86/X86InstrInfo.cpp
@@ -1049,12 +1049,11 @@ static bool findRedundantFlagInstr(MachineInstr &CmpInstr,
     // in the `AND` and `TEST` operation; signed bit is not known for `AND`,
     // and is known to be 0 as a result of `TEST64rr`.
     //
-    // FIXME: As opposed to poisoning the SF bit directly, consider peeking into
-    // the AND instruction and using the static information to guide peephole
-    // optimization if possible. For example, it's possible to fold a
-    // conditional move into a copy if the relevant EFLAG bits could be deduced
-    // from an immediate operand of and operation.
-    //
+    // FIXME: As opposed to poisoning the SF bit direclty, consider peeking into
+    // the AND instruction and using the static information to guide peephole optimization if possible.
+    // For example, it's possible to fold a conditional move into a copy
+    // if the relevant EFLAG bits could be deduced from an immediate operand of and operation.
+    // 
     NoSignFlag = true;
     // ClearsOverflowFlag is true for AND operation (no surprise).
     ClearsOverflowFlag = true;


        


More information about the llvm-commits mailing list