[PATCH] D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 17:10:46 PDT 2022


aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrRef.td:30-32
+  // Define register variants of ref.is_null for each reference type. A
+  // single stack variant of the instruction is defined later.
+  let isCodeGenOnly = 1 in
----------------
Why should the stack version and the non-stack version separately? Doesn't `I` provide a template to define both at the same time? Maybe I'm not familiar with the context.

Also why is this `isCodeGenOnly`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123484/new/

https://reviews.llvm.org/D123484



More information about the llvm-commits mailing list